Add low population features to Map Vote System - #461
Open
Faramour wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR adds two features to Map Vote system that are active when server is in "Low Population" (low player count) state:
These features function when server is at or below a player count threshold controlled by
cs2f_vote_lowpop_max_countCVAR.The nominations related feature is based on current player count, so nominations will become invalid once threshold player count is crossed. The "no cooldown on played maps" feature is based on maximum player count reached during map's playtime - cooldown does not get applied as long as maximum player count during the session was at most equal to the threshold player count.
Did very brief testing, so it might require more thorough testing on a live server to see if it works without issues.
I'd also ask if different behavior introduced by this PR would need changes or additions to chat messages to tell players why their nomination got reset or why map doesn't go on cooldown.