Skip to content

SONARJAVA-6725: Restrict rules S9130 to main code only - #5891

Open
romainbrenguier wants to merge 3 commits into
masterfrom
romain/sonarjava-6725
Open

SONARJAVA-6725: Restrict rules S9130 to main code only#5891
romainbrenguier wants to merge 3 commits into
masterfrom
romain/sonarjava-6725

Conversation

@romainbrenguier

@romainbrenguier romainbrenguier commented Aug 6, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Change scope of rules S9130 and S9133 from "All" to "Main" so they only apply to production code and not test code.

Test plan

  • Verify that rules S9130 and S9133 no longer trigger on test source files
  • Verify that rules S9130 and S9133 still trigger on main source files

🤖 Generated with Claude Code

Change scope from "All" to "Main" so that the rule only applies to
production code and not test code.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@hashicorp-vault-sonar-prod

hashicorp-vault-sonar-prod Bot commented Aug 6, 2026

Copy link
Copy Markdown
Contributor

SONARJAVA-6725

@github-actions

github-actions Bot commented Aug 6, 2026

Copy link
Copy Markdown
Contributor

Ruling needs updating. A fix PR has been created: #5892

Please review and merge it into your branch.

romainbrenguier pushed a commit that referenced this pull request Aug 6, 2026
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@github-actions

github-actions Bot commented Aug 6, 2026

Copy link
Copy Markdown
Contributor

Ruling Diff Summary

Detected changes in 2 rule files: 12 issues removed, 0 issues added.

S9130 (java) on eclipse-jetty - 7 issues removed, 0 issues added

Removed jetty-server/src/test/java/org/eclipse/jetty/server/DumpHandler.java (line 84)

(source file not found at this revision: jetty-server/src/test/java/org/eclipse/jetty/server/DumpHandler.java)

Removed jetty-server/src/test/java/org/eclipse/jetty/server/HttpServerTestBase.java (line 1379)

(source file not found at this revision: jetty-server/src/test/java/org/eclipse/jetty/server/HttpServerTestBase.java)

Removed jetty-server/src/test/java/org/eclipse/jetty/server/HttpServerTestBase.java (line 1386)

(source file not found at this revision: jetty-server/src/test/java/org/eclipse/jetty/server/HttpServerTestBase.java)

Removed jetty-server/src/test/java/org/eclipse/jetty/server/HttpServerTestBase.java (line 1407)

(source file not found at this revision: jetty-server/src/test/java/org/eclipse/jetty/server/HttpServerTestBase.java)

Removed jetty-server/src/test/java/org/eclipse/jetty/server/ssl/SSLSelectChannelConnectorLoadTest.java (line 303)

(source file not found at this revision: jetty-server/src/test/java/org/eclipse/jetty/server/ssl/SSLSelectChannelConnectorLoadTest.java)
S9130 (java) on eclipse-jetty-similar-to-main - 5 issues removed, 0 issues added - deleted ruling file

Removed jetty-server/src/test/java/org/eclipse/jetty/server/HttpServerTestBase.java (line 1379)

(source file not found at this revision: jetty-server/src/test/java/org/eclipse/jetty/server/HttpServerTestBase.java)

Removed jetty-server/src/test/java/org/eclipse/jetty/server/HttpServerTestBase.java (line 1386)

(source file not found at this revision: jetty-server/src/test/java/org/eclipse/jetty/server/HttpServerTestBase.java)

Removed jetty-server/src/test/java/org/eclipse/jetty/server/HttpServerTestBase.java (line 1407)

(source file not found at this revision: jetty-server/src/test/java/org/eclipse/jetty/server/HttpServerTestBase.java)

@romainbrenguier romainbrenguier changed the title SONARJAVA-6725: Restrict rule S9130 to main code only SONARJAVA-6725: Restrict rules S9130 and S9133 to main code only Aug 6, 2026
@github-actions

github-actions Bot commented Aug 6, 2026

Copy link
Copy Markdown
Contributor

Ruling needs updating. A fix PR has been created: #5895

Please review and merge it into your branch.

@romainbrenguier romainbrenguier changed the title SONARJAVA-6725: Restrict rules S9130 and S9133 to main code only SONARJAVA-6725: Restrict rules S9130 to main code only Aug 6, 2026
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@romainbrenguier
romainbrenguier marked this pull request as ready for review August 6, 2026 11:10
… test code

All issues in this file were in test code, which is no longer reported
since S9130 is restricted to main code only.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@gitar-bot

gitar-bot Bot commented Aug 7, 2026

Copy link
Copy Markdown
Code Review ✅ Approved

Restricts the scope of rules S9130 and S9133 to main code only and updates the ruling results accordingly. No issues found.

Options

Auto-apply is off → Gitar will not commit updates to this branch.
Display: compact → Showing less information.

Comment with these commands to change the behavior for this request:

Auto-apply Compact
gitar auto-apply:on         
gitar display:verbose         

Was this helpful? React with 👍 / 👎 | Gitar

@sonarqube-next

sonarqube-next Bot commented Aug 7, 2026

Copy link
Copy Markdown

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
0 Dependency risks
No data about Coverage
No data about Duplication

See analysis details on SonarQube

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants