BUILD-10591 Leverage setup-jfrog-cli summary in ci-github-actions#233
Draft
julien-carsique-sonarsource wants to merge 7 commits intomasterfrom
Draft
BUILD-10591 Leverage setup-jfrog-cli summary in ci-github-actions#233julien-carsique-sonarsource wants to merge 7 commits intomasterfrom
julien-carsique-sonarsource wants to merge 7 commits intomasterfrom
Conversation
- Add jfrog/setup-jfrog-cli@v4.9.1 step to build-npm, build-yarn, and build-poetry actions - Use disable-auto-build-publish: true to avoid duplicate build-info publications (builds already call jf rt build-publish manually) - Authenticate with reader access token (ARTIFACTORY_ACCESS_TOKEN) for JFrog summary links; add ARTIFACTORY_ACCESS_TOKEN to build-npm vault step (already present in build-yarn and build-poetry) - Remove jfrog-cli from mise.local.toml in build-npm, build-yarn, build-poetry (setup-jfrog-cli installs the JFrog CLI) Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
- Pin jfrog-cli version to 2.77.0 in jfrog/setup-jfrog-cli `version` input (previously managed by mise.local.toml; now managed via setup-jfrog-cli) - Add Renovate custom manager to track jfrog-cli version upgrades, following the same pattern as the jdx/mise-action version manager in SonarSource/renovate-config:default Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Also switch renovate.json to use `managerFilePatterns` (v38+ field name) instead of the deprecated `fileMatch`. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Use [\s\S]*? to skip the env: block between uses: and with:, replacing the over-engineered pattern that tried to enumerate intermediate lines step by step. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
SonarQube reviewer guide
|
Enable JFrog Job Summary for Maven and Gradle builds (even though they don't call jf directly, the summary captures build info published by the Maven/Gradle Artifactory plugins). For promote, replace mise-managed jfrog-cli with setup-jfrog-cli and add repox-url input for consistency with other actions. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add
jfrog/setup-jfrog-cli@v4.9.1to all build and promote actionsto leverage the JFrog Job Summary feature,
which automatically generates a GitHub Actions workflow summary showing artifact publishing results, curation audits,
and security scanning outcomes.
Changes per action
build-npmmise.local.tomlARTIFACTORY_ACCESS_TOKENto vault step (was missing); removed from misebuild-yarnmise.local.tomlbuild-poetrymise.local.tomlbuild-gradlebuild-mavendeploy-artifacts.sh(mixed-privacy)promotemise.local.tomlsetup-jfrog-cli; addedrepox-urlinput; removed mise step (no remaining tools)Additional changes
disable-auto-build-publish: trueon all steps — builds already calljf rt build-publishmanually in their scripts; this avoids duplicate build-info publicationsjfrog-cliversion to2.77.0via theversion:input (previously pinned inmise.local.toml).github/renovate.jsonto keep the pinned version up to daterenovatebot/pre-commit-hooksfrom37.418.1to43.76.3to support themanagerFilePatternsfieldTest plan
ARTIFACTORY_PROMOTE_ACCESS_TOKENfor JFrog CLI setup)