Fix missing menu - use new auth#700
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the left-side navigation menu’s authentication detection to align with newer solid-logic behavior, where authSession.info.isLoggedIn is no longer a reliable indicator and auth state may require an async refresh via checkUser().
Changes:
- Add an async auth refresh helper (
refreshAuthStateFromSession) that callsauthn.checkUser()before determining menu visibility. - Ensure auth state is refreshed during menu initialization and on
login/logout/sessionRestoreevents before re-rendering the menu.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
use new auth for displaying side menu. isLoggedIn was no longer a dependable way of checking auth state, needed checkuser, also solid-logic is now async.