Open
Conversation
Creating new path and schema placeholder to address new endpoint being addded. TODO populate schema and path description with details of the object structure and permissions respectively.
Provided detailed schema of the object representing output from the endpoint. All fields, combinations and endpoint itself include examples to visualize the result.
There was a problem hiding this comment.
Pull request overview
Adds a new SHIELD OpenAPI schema and endpoint for returning a Zero Trust Assessment object, and bumps the TypeScript SDK/spec versions accordingly.
Changes:
- Bump
@shi-corp/sdk-shieldversion from3.3.0to3.4.0(and align lockfile). - Add
ZeroTrustAssessmentschema definition with extensive examples. - Add
GET /Api/Discover/ZeroTrustendpoint returning theZeroTrustAssessmentschema with an example payload.
Reviewed changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated 8 comments.
| File | Description |
|---|---|
| src/shield/TypeScript/package.json | Version bump to publish updated SDK artifacts. |
| src/shield/TypeScript/package-lock.json | Lockfile version alignment with package version bump. |
| specs/SHIELD.json | Introduces ZeroTrustAssessment schema + new Discover endpoint and bumps spec version. |
Files not reviewed (1)
- src/shield/TypeScript/package-lock.json: Language not supported
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Set count properties as integers with format and minimum values instead of just number type
Adding use of existing permission until another decision is made.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 2 out of 3 changed files in this pull request and generated 3 comments.
Files not reviewed (1)
- src/shield/TypeScript/package-lock.json: Language not supported
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added new schema definition for the object structure of the assessment.
Included extensive examples throughout the schema.
Added example to the endpoint for presentation in Swagger.