Skip to content

Fix SNaBorderedWindow drag detection and resize coordinate space bugs #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Copilot wants to merge 3 commits into from
Closed

Fix SNaBorderedWindow drag detection and resize coordinate space bugs #21

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
898b066
Initial plan
Copilot Feb 24, 2026
530a82f
fix: correct coordinate space in SNaBorderedWindow drag/resize and in…
Copilot Feb 24, 2026
728ac11
test assets
SodiumZH Feb 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Binary file modified Content/TestResource/TestBP/TestMob.uasset
View file
Open in desktop
Binary file not shown.
Binary file modified Content/TestResource/TestBP/TestPlayerController.uasset
View file
Open in desktop
Binary file not shown.
Binary file added Plugins/NaWidgets/Content/UI/BorderedWindowTest.uasset
View file
Open in desktop
Binary file not shown.
Binary file added Plugins/NaWidgets/Content/UI/cross_test.uasset
View file
Open in desktop
Binary file not shown.
12 changes: 8 additions & 4 deletions Plugins/NaWidgets/Source/NaWidgets/Private/Widgets/WindowWidgets/SNaBorderedWindow.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -174,7 +174,9 @@ FReply SNaBorderedWindow::OnMouseButtonDown(const FGeometry& MyGeometry, const F
if (MouseEvent.GetEffectingButton() == EKeys::LeftMouseButton)
{
const FVector2D LocalPos = MyGeometry.AbsoluteToLocal(MouseEvent.GetScreenSpacePosition());
const EWindowRegion Region = GetRegionAtPosition(MyGeometry, LocalPos);
// Offset into inner-canvas space by subtracting the current window position
const FVector2D CanvasLocalPos = LocalPos - WindowPosition;
const EWindowRegion Region = GetRegionAtPosition(MyGeometry, CanvasLocalPos);

if (Region == EWindowRegion::TopBorder)
{
Expand All @@ -186,7 +188,7 @@ FReply SNaBorderedWindow::OnMouseButtonDown(const FGeometry& MyGeometry, const F
else if (Region == EWindowRegion::BottomRightCorner)
{
bIsResizing = true;
DragStartPosition = LocalPos;
DragStartPosition = CanvasLocalPos;
DragStartBodySize = Params.BodySize;
return FReply::Handled().CaptureMouse(SharedThis(this));
}
Expand Down Expand Up @@ -215,7 +217,9 @@ FReply SNaBorderedWindow::OnMouseMove(const FGeometry& MyGeometry, const FPointe
if (bIsResizing)
{
const FVector2D CurrentPos = MyGeometry.AbsoluteToLocal(MouseEvent.GetScreenSpacePosition());
const FVector2D Delta = CurrentPos - DragStartPosition;
// Offset into inner-canvas space to match DragStartPosition coordinate system
const FVector2D CanvasLocalPos = CurrentPos - WindowPosition;
const FVector2D Delta = CanvasLocalPos - DragStartPosition;

FVector2D NewBodySize = DragStartBodySize + Delta;
Params.BodySize = ClampBodySize(NewBodySize);
Expand All @@ -226,7 +230,7 @@ FReply SNaBorderedWindow::OnMouseMove(const FGeometry& MyGeometry, const FPointe
{
const FVector2D Delta = MouseEvent.GetScreenSpacePosition() - DragStartPosition;
WindowPosition = DragStartWindowPosition + Delta;
OuterCanvas->Invalidate(EInvalidateWidgetReason::Layout);
OuterCanvas->Invalidate(EInvalidateWidgetReason::LayoutAndVolatility);
return FReply::Handled();
}

Expand Down
Loading