Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: bf7410e198
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| "status": "scaffold", | ||
| }) | ||
| }}, | ||
| &cobra.Command{Use: "promote", Short: "Promote the current validated context set", RunE: func(cmd *cobra.Command, args []string) error { |
There was a problem hiding this comment.
Reject unexpected positional args for promote
The promote subcommand sets RunE without an Args validator, so Cobra will accept extra positional arguments and still return success (for example, prophet vocab promote typo). That makes automation and operator mistakes hard to detect because invalid invocations look successful. Adding Args: cobra.NoArgs here (and similarly on other no-arg verbs like sr gate) would make this command fail fast on malformed input.
Useful? React with 👍 / 👎.
Summary
Adds the first Ontogenesis-facing runtime surface to
prophet-cli.Included
prophet vocabcommandfetch,validate,promote, andsrfaçade subcommandsvocabsubtreeWhy
The standards-side semantic core and validator stack are now staged in
socioprophet-standards-knowledgethrough PRs #28-#31. The runtime CLI now needs a command surface that can consume those standards without forcing users into the standards repo directly.This PR is intentionally narrow and additive. It creates the façade contract first before wiring real execution, CI, or K8s/bindings enforcement.
What this does not yet do
validate_all.pyThose should follow as the next runtime PRs.