auth/opa: add WithStore option and fix concurrent print-buffer race#620
Open
sfc-gh-ikryvanos wants to merge 1 commit into
Open
auth/opa: add WithStore option and fix concurrent print-buffer race#620sfc-gh-ikryvanos wants to merge 1 commit into
sfc-gh-ikryvanos wants to merge 1 commit into
Conversation
Add a WithStore option to NewOpaAuthzPolicy so a policy can be parameterized through the `data` document (for example data.config) instead of hard-coding values in the policy file. The supplied store is applied to both the allow query and the denial-hints query. Also fix a data race: opaAuthzPolicy shared a single bytes.Buffer for rego print output across all evaluations, and that buffer is written concurrently whenever Eval is called from multiple goroutines (the normal case for a gRPC server). Each Eval now uses its own buffer, supplied per call via rego.EvalPrintHook. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a WithStore option to NewOpaAuthzPolicy so a policy can be parameterized through the
datadocument (for example data.config) instead of hard-coding values in the policy file. The supplied store is applied to both the allow query and the denial-hints query.Also fix a data race: opaAuthzPolicy shared a single bytes.Buffer for rego print output across all evaluations, and that buffer is written concurrently whenever Eval is called from multiple goroutines (the normal case for a gRPC server). Each Eval now uses its own buffer, supplied per call via rego.EvalPrintHook.