fix: register noop handlers for missing Kavita SignalR events#315
Open
xxxarmitagexxx wants to merge 2 commits into
Open
fix: register noop handlers for missing Kavita SignalR events#315xxxarmitagexxx wants to merge 2 commits into
xxxarmitagexxx wants to merge 2 commits into
Conversation
Kavita sends a ChapterUpdated event with a payload containing SeriesId and ChapterId, but Komf had no handler registered for it. The SignalR client logged WARN/ERROR on every chapter update due to the argument count mismatch (1 provided, 0 expected). Add ChapterUpdatedEvent model matching Kavita's payload and register a noop handler in registerInvocations() alongside the other ignored events.
xxxarmitagexxx
changed the title
xxxarmitagexxx
force-pushed
the
fix/kavita-chapter-updated-signalr
branch
from
4326c16 to
d161b38
Compare
xxxarmitagexxx
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Kavita's SignalR hub sends several events that Komf has no handler registered for. The Microsoft SignalR client logs errors on every occurrence:
No functional impact — REST API metadata updates still succeed — but the errors pollute logs continuously.
Fixes #314
Changes:
ChapterUpdatedEventmodel matching Kavita's payload (SeriesId: Int,ChapterId: Int) following the existing event model patternChapterUpdatedinregisterInvocations()inKavitaEventHandlerReadingSessionUpdateandReadingSessionClosewhich have the same issueComplementary to #309, no compatibility issues.