2 add the capability to search for documents metadata#25
Merged
ChristopheBeke merged 52 commits intodevfrom Jul 1, 2025
Merged
2 add the capability to search for documents metadata#25ChristopheBeke merged 52 commits intodevfrom
ChristopheBeke merged 52 commits intodevfrom
Conversation
…google drive documents
…added tests for the new search functionality.
…o 2-add-the-capability-to-search-for-documents-metadata
…le_drive_client.py' of the docbinder-oss repository.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
… doc/16-doc-how-to-add-a-new-provider
… 2-add-the-capability-to-search-for-documents-metadata
PaoloLeonard
requested changes
Jun 22, 2025
…search-for-documents-metadata-paolo Bugfix/2 add the capability to search for documents metadata paolo
…vider Doc/16 doc how to add a new provider
ChristopheBeke
commented
Jun 23, 2025
Contributor
Author
ChristopheBeke
left a comment
ChristopheBeke
left a comment
There was a problem hiding this comment.
Feedback work done in new update
src/docbinder_oss/commands/search.py
Outdated
Comment on lines
60
to
74
| def build_path(item): | ||
| # Reconstruct the path by walking up parents | ||
| path_parts = [item.name] | ||
| current = item | ||
| seen = set() | ||
| while getattr(current, "parents", None): | ||
| parent_ids = current.parents if isinstance(current.parents, list) else [current.parents] | ||
| parent_id = parent_ids[0] if parent_ids else None | ||
| if not parent_id or parent_id in seen or parent_id not in all_items_by_id: | ||
| break | ||
| seen.add(parent_id) | ||
| parent = all_items_by_id[parent_id] | ||
| path_parts.append(parent.name) | ||
| current = parent | ||
| return "/".join(reversed(path_parts)) |
Contributor
Author
There was a problem hiding this comment.
This is gone?
…ully adds all required fields for csv and json.
https://github.com/SnappyLab/DocBinder-OSS into improve-gdrive-integration
…yLab/DocBinder-OSS into 36-add-better-writer-support
36 add better writer support
Improve gdrive integration
…on to now show which extensions are supported.
…n the tests with it.
…anged the reference name of docbinder documentation to be more correct
…ve-test Revert back to writer and improve test
ChristopheBeke
deleted the
2-add-the-capability-to-search-for-documents-metadata
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
Description
Please include a summary of the change and which issue is fixed. Also include relevant motivation and context.
Fixes # (issue)
Type of change
Checklist