Add native API versioning and compatibility guards#126
Conversation
| @@ -0,0 +1,2 @@ | |||
| <?xml version="1.0" encoding="utf-8"?> | |||
| <manifest xmlns:android="http://schemas.android.com/apk/res/android" package="com.snap.valdi.empty" /> | |||
There was a problem hiding this comment.
Semgrep identified an issue in your code:
This literal might contain a Snapchat internal reference that should not be committed to open-source repositories.
Fix: Please replace / remove the string to avoid committing it to open-source repositories.
To resolve this comment:
✨ Commit fix suggestion
- Replace the internal package name in the manifest with a neutral open-source identifier that does not include
.snap, for example changepackage="com.snap.valdi.empty"to something likepackage="com.example.valdi.empty". - Keep the new package value consistent with the module’s intended public namespace so Android tooling still treats it as the app/package identifier.
- Alternatively, if this manifest is only a placeholder or test fixture, remove the
packageattribute entirely when it is not required by the file’s purpose.
💬 Ignore this finding
Reply with Semgrep commands to ignore this finding.
/fp <comment>for false positive/ar <comment>for acceptable risk/other <comment>for all other reasons
Alternatively, triage in Semgrep AppSec Platform to ignore the finding created by internal-sensitive-strings.
You can view more details about this finding in the Semgrep AppSec Platform.
Sensitive Files Detected🔧 Build rules — Affects build rules for all Valdi consumers. This is an automated notice. A maintainer will review after import. |
🎉 Bazel & CI Test Results
All Bazel configuration and CI tests passed! ✨ The build system and core tooling are working correctly. 🚀 Bazel remote cache is now enabled - future builds will be faster! Workflow: Valdi CI |
Description
This change adds support for runtime versioning. It is designed to allow TS code to safely drift apart from its underlying native runtime.
The key concepts are as follow:
@Version()and an arbitrary int versionisVersionAtLeast().isVersionAtLeast()Type of Change
Testing
bazel test //...)Testing Details
Checklist
Related Issues
Additional Context