Add renderer memoization and reconciliation fixes#125
Open
scorsin-oai wants to merge 1 commit into
Open
Conversation
🎉 Bazel & CI Test Results
All Bazel configuration and CI tests passed! ✨ The build system and core tooling are working correctly. 🚀 Bazel remote cache is now enabled - future builds will be faster! Workflow: Valdi CI |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This change adds the
remember()API which works kind of like React'suseMemo()or Jetpack Composeremember(). Unlike React, this API doesn't just work on the nearest ancestor component, it works on the nearest node that is at the top,.It also fixes a reconcilation bug which could cause duplicate keys when it shouldn't, and it fixes a crash that could occur when a node has its viewClass being changed.
Type of Change
Testing
bazel test //...)Testing Details
Checklist
Related Issues
Additional Context