Skip to content

Add linear and radial gradients for shape fills#123

Open
scorsin-oai wants to merge 2 commits into
Snapchat:mainfrom
scorsin-oai:simon/260723-shape-fill-gradients
Open

Add linear and radial gradients for shape fills#123
scorsin-oai wants to merge 2 commits into
Snapchat:mainfrom
scorsin-oai:simon/260723-shape-fill-gradients

Conversation

@scorsin-oai

Copy link
Copy Markdown
Collaborator

Description

This change adds support for fillGradient on the shape element.

Type of Change

  • Bug fix (non-breaking change that fixes an issue)
  • Documentation improvement
  • Performance optimization
  • Test improvement
  • Other (please describe)

Testing

  • Tests pass locally (bazel test //...)
  • Added/updated tests for changes (if applicable)
  • Tested on multiple platforms (iOS/Android/Web/macOS as applicable)
  • Manual testing performed (describe below)

Testing Details

Checklist

  • Code follows project style guidelines
  • Documentation updated (if needed)
  • No breaking changes (or documented in description)
  • Commit messages follow conventional format
  • No secrets, API keys, or internal URLs included

Related Issues

Additional Context

@github-actions github-actions Bot added area/runtime Valdi runtime (C++/native) area/snap-drawing SnapDrawing library labels Jul 23, 2026
@scorsin-oai

Copy link
Copy Markdown
Collaborator Author

Will add iOS impl before merging the PR

@github-actions github-actions Bot added the platform/ios iOS-specific label Jul 23, 2026
@github-actions

github-actions Bot commented Jul 23, 2026

Copy link
Copy Markdown

⚠️ Bazel & CI Test Results

Test Suite Result
Valdi Smoke Tests ✅ success
API Surface Check ✅ success
Snapshot Tests ✅ success
Linux: Build Compiler ✅ success
macOS: C++ & Platform Tests ✅ success
Linux: C++ Tests ✅ success
Linux: Build & Export ❌ failure

Some tests failed. Please check the workflow logs for details.

🚀 Bazel remote cache is now enabled - future builds will be faster!

Workflow: Valdi CI

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/runtime Valdi runtime (C++/native) area/snap-drawing SnapDrawing library platform/ios iOS-specific

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant