Add tests/smoke suite that runs Vertex AI tests against a fresh source image#668
Draft
kmontemayor2-sc wants to merge 6 commits into
Draft
Add tests/smoke suite that runs Vertex AI tests against a fresh source image#668kmontemayor2-sc wants to merge 6 commits into
kmontemayor2-sc wants to merge 6 commits into
Conversation
…e image Relocate the two non-e2e tests that launch real Vertex AI jobs (networking_test, vertex_ai_test) into a new tests/smoke/ package with its own main.py, and add a `make smoke_test` target that builds a fresh src-cpu image from the current source and runs them against it (via GIGL_CPU_DOCKER_URI). This closes a source/image skew gap: `make integration_test` runs workers on the pinned release image, so worker-side source changes (e.g. get_graph_store_info) were only validated after a release. smoke_test rebuilds from current source so they're validated on the PR. - Makefile: SMOKE_TEST_CPU_IMAGE_TAG / SMOKE_TEST_CPU_IMAGE vars + smoke_test target. - CI: run `make smoke_test` in on-pr-merge's ci-integration-test, and add a `/smoke_test` (+ /all_test) on-demand job to on-pr-comment. Both pass an immutable per-run tag (run_id.run_attempt) so concurrent runs can't clobber it. - networking_test: worker runs a real _assert_graph_store_info() function (thin python -c import+call) instead of an inlined script, now that the image is rebuilt from source. - vertex_ai_test: the CustomJob tests run a real worker function asserting the provisioned machine's vCPU count, on the fresh image. - All smoke job configs set an explicit short timeout_s. - Document make smoke_test / tests/smoke in CLAUDE.md and README.md. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Collaborator
Author
|
/all_test |
Contributor
GiGL Automation@ 16:52:25UTC : 🔄 @ 16:54:20UTC : ✅ Workflow completed successfully. |
Contributor
GiGL Automation@ 16:52:26UTC : 🔄 @ 17:43:25UTC : ✅ Workflow completed successfully. |
Contributor
GiGL Automation@ 16:52:27UTC : 🔄 @ 17:00:32UTC : ❌ Workflow failed. |
Contributor
GiGL Automation@ 16:52:28UTC : 🔄 @ 17:55:27UTC : ✅ Workflow completed successfully. |
Contributor
GiGL Automation@ 16:52:28UTC : 🔄 @ 18:12:45UTC : ✅ Workflow completed successfully. |
Contributor
GiGL Automation@ 16:52:33UTC : 🔄 @ 17:01:20UTC : ✅ Workflow completed successfully. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow up #666 - would have caught this error much earlier.
Tested this with https://github.com/Snapchat/GiGL/actions/runs/26966650689, will making this a blocking test after submission.
Relocate the two non-e2e tests that launch real Vertex AI jobs (networking_test, vertex_ai_test) into a new tests/smoke/ package with its own main.py, and add a
make smoke_testtarget that builds a fresh src-cpu image from the current source and runs them against it (via GIGL_CPU_DOCKER_URI).This closes a source/image skew gap:
make integration_testruns workers on the pinned release image, so worker-side source changes (e.g. get_graph_store_info) were only validated after a release. smoke_test rebuilds from current source so they're validated on the PR.make smoke_testin on-pr-merge's ci-integration-test, and add a/smoke_test(+ /all_test) on-demand job to on-pr-comment. Both pass an immutable per-run tag (run_id.run_attempt) so concurrent runs can't clobber it.Scope of work done
Where is the documentation for this feature?: N/A
Did you add automated tests or write a test plan?
Updated Changelog.md? NO
Ready for code review?: NO