Narrow storage.Client.project to str once in GcsUtils.__init__#665
Draft
kmontemayor2-sc wants to merge 1 commit into
Draft
Narrow storage.Client.project to str once in GcsUtils.__init__#665kmontemayor2-sc wants to merge 1 commit into
kmontemayor2-sc wants to merge 1 commit into
Conversation
storage.Client.__init__ raises if no project can be determined, so the .project attribute is always a str at the next line. The upstream stub in google-cloud-storage annotates it as Optional[str], forcing a ty ignore at every call site. Narrow once in __init__ with a fail-fast TypeError guard (per CLAUDE.md) and reuse via self.__project: str. Patches tests/unit/utils/gcs_test.py to set mock_client.project on the two MagicMock(spec=Client) fixtures so the runtime guard accepts them. Resolves 1 `# ty: ignore[invalid-argument-type]` at gcs.py:136. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
kmontemayor2-sc
force-pushed
the
kmontemayor/ty_gcs_project_narrowing
branch
from
8d8c644 to
d7d970b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
storage.Client.init raises if no project can be determined, so the .project attribute is always a str at the next line. The upstream stub in google-cloud-storage annotates it as Optional[str], forcing a ty ignore at every call site. Narrow once in init with a fail-fast TypeError guard (per CLAUDE.md) and reuse via self.__project: str.
Patches tests/unit/utils/gcs_test.py to set mock_client.project on the two MagicMock(spec=Client) fixtures so the runtime guard accepts them.
Resolves 1
# ty: ignore[invalid-argument-type]at gcs.py:136.Scope of work done
Where is the documentation for this feature?: N/A
Did you add automated tests or write a test plan?
Updated Changelog.md? NO
Ready for code review?: NO