add a visual indicator of the object's origin when displaying a Bracket#2
Open
sdumetz wants to merge 2 commits intoSmithsonian:masterfrom
Open
add a visual indicator of the object's origin when displaying a Bracket#2sdumetz wants to merge 2 commits intoSmithsonian:masterfrom
sdumetz wants to merge 2 commits intoSmithsonian:masterfrom
Conversation
Author
|
Looks like I have a bug here where the Bracket disappear during loading when used as a blue placeholder. I'll have to work this out. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The changes are pretty much self-explanatory : Add an axis helper on the "Bracket" showing the selected object's bound to indicate it's transform origin.
This would help communicate the difference between Pose/Position (move relative to transform origin) and Settings/Transform (move the pivot point)
In the future, this "AxesHelper" could be extended to provide "handles" to move the object in the 3D space. For the moment it's just a visual helper.
The styling is THREE's default helper, I found it more readable than an all-yellow helper but other color choices are obviously possible.