Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions drivers/SmartThings/matter-sensor/fingerprints.yml
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@ matterManufacturer:
deviceLabel: Heiman Smoke Sensor
vendorId: 0x120B
productId: 0x1006
deviceProfileName: smoke
deviceProfileName: smoke-heiman
- id: "4619/4098"
deviceLabel: Heiman CO Sensor
vendorId: 0x120B
Expand All @@ -73,7 +73,7 @@ matterManufacturer:
deviceLabel: Heiman Smoke Sensor
vendorId: 0x120B
productId: 0x1003
deviceProfileName: smoke
deviceProfileName: smoke-heiman
- id: "4619/4103"
deviceLabel: Smart co sensor
vendorId: 0x120B
Expand Down
16 changes: 16 additions & 0 deletions drivers/SmartThings/matter-sensor/profiles/smoke-heiman.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,16 @@
name: smoke-heiman

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we update this name to something like smoke-no-sensitivity in case it is used by other devices in the future. In general, we should avoid including manufacturer names in profiles so they can be used elsewhere as needed.

components:
- id: main
capabilities:
- id: smokeDetector
version: 1
- id: hardwareFault
version: 1
- id: batteryLevel
version: 1
- id: firmwareUpdate
version: 1
- id: refresh
version: 1
categories:
- name: SmokeDetector
4 changes: 4 additions & 0 deletions drivers/SmartThings/matter-sensor/src/sensor_utils/fields.lua
Original file line number Diff line number Diff line change
Expand Up @@ -52,6 +52,10 @@ SensorFields.BOOLEAN_CAP_EVENT_MAP = {
SensorFields.vendor_overrides = {
[0x115F] = { -- AQARA_MANUFACTURER_ID
[0x2009] = { is_aqara_fp400 = true }
},
[0x120B] = { -- Heiman
[0x1003] = {target_profile = "smoke-heiman"},
[0x1006] = {target_profile = "smoke-heiman"}
}
}

Expand Down
Loading