Skip to content

Default handler missing log require patch #3101

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
aleclorimer wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Default handler missing log require patch #3101

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 34 additions & 0 deletions ...zigbee-switch/src/st/zigbee/defaults/powerMeter_defaults/instantaneous_demand_handler.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,34 @@
-- Copyright 2026 SmartThings, Inc.
-- Licensed under the Apache License, Version 2.0

local capabilities = require "st.capabilities"
local constants = require "st.zigbee.constants"
local log = require "log"

--- Default handler for InstantaneousDemand attribute on SimpleMetering cluster
---
--- This converts the Int24 instantaneous demand into the powerMeter.power capability event. This will
--- check the device for values set in the constants.SIMPLE_METERING_MULTIPLIER_KEY and
--- constants.SIMPLE_METERING_DIVISOR_KEY to convert the raw value to the correctly scaled values. These
--- fields should be set by reading the values from the same cluster
---
--- @param driver ZigbeeDriver The current driver running containing necessary context for execution
--- @param device st.zigbee.Device The device this message was received from containing identifying information
--- @param value st.zigbee.data_types.Int24 the value of the instantaneous demand
--- @param zb_rx st.zigbee.ZigbeeMessageRx the full message this report came in
return function(driver, device, value, zb_rx)
local raw_value = value.value
--- demand = demand received * Multipler/Divisor
local multiplier = device:get_field(constants.SIMPLE_METERING_MULTIPLIER_KEY) or 1
local divisor = device:get_field(constants.SIMPLE_METERING_DIVISOR_KEY) or 1

if divisor == 0 then
log.warn_with({ hub_logs = true }, "Simple metering divisor is 0; using 1 to avoid division by zero")
divisor = 1
end

raw_value = raw_value * multiplier/divisor

local raw_value_watts = raw_value * 1000
device:emit_event_for_endpoint(zb_rx.address_header.src_endpoint.value, capabilities.powerMeter.power({value = raw_value_watts, unit = "W" }))
end
Loading