add wallhero_thermostat_ACL-403STC1#2969
Open
thinkaName wants to merge 1 commit into
Open
Conversation
|
Duplicate profile check: Passed - no duplicate profiles detected. |
|
Invitation URL: |
|
Minimum allowed coverage is Generated by 🐒 cobertura-action against 732b396 |
cbaumler
reviewed
May 26, 2026
thinkaName
force-pushed
the
wallhero_thermostat_ACL-403STC1
branch
from
f628c54 to
732b396
Compare
aleclorimer
reviewed
May 28, 2026
Comment on lines
+106
to
+112
| socket.sleep(1)--Avoid wireless congestion and packet loss | ||
| device:send_to_component("main", Thermostat.attributes.SystemMode:read(device)) | ||
| device:send_to_component("main", FanControl.attributes.FanMode:read(device)) | ||
| socket.sleep(1) | ||
| device:send_to_component("fan", OnOff.attributes.OnOff:read(device)) | ||
| device:send_to_component("fan", FanControl.attributes.FanMode:read(device)) | ||
| socket.sleep(1) |
Contributor
There was a problem hiding this comment.
These sleeps are not necessary. We rate limit to avoid congestion on our hubs
aleclorimer
reviewed
May 28, 2026
| local function endpoint_to_component(device, ep) | ||
| if ep > 3 then | ||
| ep = ep - 3 | ||
| local button_comp = string.format("button%d+", ep) |
Contributor
There was a problem hiding this comment.
Suggested change
| local button_comp = string.format("button%d+", ep) | |
| local button_comp = string.format("button%d", ep) |
Erroneous character
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Check all that apply
Type of Change
Checklist
Description of Change
Summary of Completed Tests