Matter Switch: Explicitly check default endpoint for Water Valves#2900
Merged
hcarter-775 merged 1 commit intomainfrom Apr 14, 2026
Merged
Matter Switch: Explicitly check default endpoint for Water Valves#2900hcarter-775 merged 1 commit intomainfrom
hcarter-775 merged 1 commit intomainfrom
Conversation
|
Channel deleted. |
Test Results 72 files 499 suites 0s ⏱️ Results for commit d04ecd9. |
|
Minimum allowed coverage is Generated by 🐒 cobertura-action against d04ecd9 |
tpmanley
approved these changes
Apr 14, 2026
ctowns
approved these changes
Apr 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Change
Today, the VDA version of the Water Valve that is often used for testing includes an on/off endpoint on its first endpoint, the same endpoint that exposes Water Valve. Therefore, the VDA version of this device type is currently exposed with the
switch-binaryprofile today. This should not affect live water valve devices, since they should not be exposing the onoff cluster on any endpoint. However, since it is allowed per spec, and since it is exposed on a test Matter device today, this fixes the issue.Further, it fixes any generic issues in which the Water Valve is exposed on an endpoint that does not match the
MATTER_DEFAULT_ENDPOINT, and simplifies the checks infind_default_endpoint.Summary of Completed Tests