Matter Switch: Add nil check handling for electrical sensor handlers#2899
Merged
hcarter-775 merged 1 commit intomainfrom Apr 14, 2026
Merged
Matter Switch: Add nil check handling for electrical sensor handlers#2899hcarter-775 merged 1 commit intomainfrom
hcarter-775 merged 1 commit intomainfrom
Conversation
|
Channel deleted. |
Test Results 72 files 499 suites 0s ⏱️ Results for commit a883224. |
|
Minimum allowed coverage is Generated by 🐒 cobertura-action against a883224 |
ctowns
approved these changes
Apr 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Change
Normally, these handlers should return early if the profiling_data they help populate have already been filled. However, under certain conditions, a device can 1. end up with us doing a wildcard subscription where we subscribe to every attribute/event it supports, and 2. be handled in a subdriver where the profiling data never gets populated. The fact that a subdriver/driver relationship is not necessarily of 2 distinct pieces (the partsList is an attribute supported by every device, for example) means we should probably work towards removing the separation between lifecycle handlers on generic devices (see this PR), but in the meantime we should probably fix this issue we're seeing in the field.
Summary of Completed Tests