Matter Camera: Fix bugs related to profile matching and re-init of capabilites#2887
Open
samadDotDev wants to merge 2 commits intomainfrom
Open
Matter Camera: Fix bugs related to profile matching and re-init of capabilites#2887samadDotDev wants to merge 2 commits intomainfrom
samadDotDev wants to merge 2 commits intomainfrom
Conversation
|
Invitation URL: |
|
Minimum allowed coverage is Generated by 🐒 cobertura-action against 1094ae3 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of Change
Checklist
Description of Change
I started with a fix to feature-map change, which if occurred on a SW update and didn't result in a profile change won't re-init or update any capability attributes (such as
supportedFeatures) that should be updated on such changes.In a specific example, I observed one of the cameras getting updated for its watermark/OSD bits in feature map of AVSM cluster, and despite the SW update (which triggered the
infoChangedhandler with SW version diff), thevideoStreamSettings::supportedFeatureswasn't updated to reflect the changes in watermark/OSD support.While addressing this issue I noticed that this was applicable to other capabilities and features as well, so I refactored that a bit. There were a few more issues that I addressed as part of this PR since they were tightly linked with the new changes to observe these diffs:
ConfigurationVersionfrom spec) then we still reflect those changes in profile and/or relevant supported features of capabilities.AttributesList, I believe we aren't tracking FeatureMap global attribute for clusters in the Lua libs, so this is defined as a const until then. This was also surfaced in the recent interest of Door Lock TF in subscribing to feature map changes.supportedFeatureof a capability, disabling it in profile, re-enabling it - we'd want to re-upsert thesupportedFeatureeven if there is no diff in that case)vision.clipAnalysis- it will result in aninfoChangedwith profile diff that'd previously call the re-init of all capabilities.AttributesListhandler. This was handled previously too, but wasn't tracked, so there was a bug where this could be reset (removing the status led components from profile) if you receive theAttributesListfirst and then another event occurred which would re-match the profile from various paths (as that re-match was defaulting tofalsefor all spots outside ofAttributesListhandler). We can't rely (yet) on the attributes list within device's object (unlike feature map) due to this being potentially empty, hence it is tracked based on last report received for this attribute, and then used in any future re-matches from any path.Summary of Completed Tests
infoChanged) of existing camera