Skip to content

Thermostat setpoint range test #2884

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ctowns wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Thermostat setpoint range test #2884

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
81a4f35
rolling up main to beta 2026-04-01 (#2871)
ctowns Apr 2, 2026
634a370
Thermostat Setpoint Range Test
ctowns Apr 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions drivers/SmartThings/matter-thermostat/src/thermostat_handlers/attribute_handlers.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -177,7 +177,9 @@ function AttributeHandlers.abs_heat_setpoint_limit_factory(minOrMax)
-- Only emit the capability for RPC version >= 5 (unit conversion for
-- heating setpoint range capability is only supported for RPC >= 5)
if version.rpc >= 5 then
device:emit_event_for_endpoint(ib.endpoint_id, capabilities.thermostatHeatingSetpoint.heatingSetpointRange({ value = { minimum = min, maximum = max, step = 0.1 }, unit = "C" }))
device:set_field(fields.setpoint_limit_device_field.MIN_HEAT, 4.5)
device:set_field(fields.setpoint_limit_device_field.MAX_HEAT, 32)
device:emit_event_for_endpoint(ib.endpoint_id, capabilities.thermostatHeatingSetpoint.heatingSetpointRange({ value = { minimum = 4.5, maximum = 32, step = 0.1 }, unit = "C" }))
end
else
device.log.warn_with({hub_logs = true}, string.format("Device reported a min heating setpoint %d that is not lower than the reported max %d", min, max))
Expand All @@ -201,7 +203,9 @@ function AttributeHandlers.abs_cool_setpoint_limit_factory(minOrMax)
-- Only emit the capability for RPC version >= 5 (unit conversion for
-- cooling setpoint range capability is only supported for RPC >= 5)
if version.rpc >= 5 then
device:emit_event_for_endpoint(ib.endpoint_id, capabilities.thermostatCoolingSetpoint.coolingSetpointRange({ value = { minimum = min, maximum = max, step = 0.1 }, unit = "C" }))
device:set_field(fields.setpoint_limit_device_field.MIN_COOL, 15.5)
device:set_field(fields.setpoint_limit_device_field.MAX_COOL, 37)
device:emit_event_for_endpoint(ib.endpoint_id, capabilities.thermostatCoolingSetpoint.coolingSetpointRange({ value = { minimum = 15.5, maximum = 37, step = 0.1 }, unit = "C" }))
end
else
device.log.warn_with({hub_logs = true}, string.format("Device reported a min cooling setpoint %d that is not lower than the reported max %d", min, max))
Expand Down
Loading