CHAD-12653 Zigbee: Add support for reading ColorTemperatureRange#2779
Open
CHAD-12653 Zigbee: Add support for reading ColorTemperatureRange#2779
Conversation
greens
requested review from
cjswedes,
hcarter-775,
nickolas-deboom,
pegor-karoglanian and
wkhenon
|
Invitation URL: |
Test Results 72 files ± 0 487 suites +1 0s ⏱️ ±0s Results for commit 662fce3. ± Comparison against base commit 5f76622. This pull request removes 2 and adds 17 tests. Note that renamed tests count towards both.♻️ This comment has been updated with latest results. |
|
Minimum allowed coverage is Generated by 🐒 cobertura-action against 662fce3 |
hcarter-775
reviewed
Feb 19, 2026
drivers/SmartThings/zigbee-switch/src/color_temp_range_handlers/can_handle.lua
Show resolved
Hide resolved
hcarter-775
reviewed
Feb 19, 2026
hcarter-775
reviewed
Feb 19, 2026
update fingerprints pointing to specific ranges
greens
force-pushed
the
feature/color_temp_range
branch
from
e462a97 to
9c79973
Compare
hcarter-775
reviewed
Feb 25, 2026
| deviceLabel: Innr Light | ||
| manufacturer: innr | ||
| model: RB 250 C | ||
| deviceProfileName: rgbw-bulb-1800K-6500K |
Contributor
There was a problem hiding this comment.
In the case that these devices are mis-handling their color temp bounds, we may want to leave the profile as they are?
cjswedes
reviewed
Feb 25, 2026
| return | ||
| end | ||
| local temp_in_kelvin = utils.round(MIREDS_CONVERSION_CONSTANT / temp_in_mired) | ||
| device:set_field(MIREDS_MAX..endpoint, temp_in_kelvin) |
Contributor
There was a problem hiding this comment.
- How come the temp in kelvin is getting stored to a key for mireds? This is a bit confusing
- Also, why is it the MAX value used rather than the min value? I assume this is just how the colors work, so maybe a comment explaining why min mireds -> max kelvin.
| can_handle = require("color_temp_range_handlers.can_handle") | ||
| } | ||
|
|
||
| return color_temp_range_handlers No newline at end of file |
wkhenon
reviewed
Feb 25, 2026
Comment on lines
+6
to
+8
| local COLOR_CONTROL_ID = 0x0300 | ||
| local COLOR_TEMP_PHYSICAL_MIN_MIREDS_ID = 0x0400B | ||
| local COLOR_TEMP_PHYSICAL_MAX_MIREDS_ID = 0x0400C |
Contributor
There was a problem hiding this comment.
Should we require "st.zigbee.zcl.clusters" for this file? Or are there some memory/performance savings we're getting by defining the constants?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.