add timeout setting - #1910
Open
art0007i wants to merge 7 commits into
Open
Conversation
art0007i
requested review from
ButterscotchV,
Erimelowo and
loucass003
as code owners
August 15, 2026 11:40
loucass003
requested changes
Aug 15, 2026
Erimelowo
approved these changes
Aug 18, 2026
Erimelowo
left a comment
Erimelowo
left a comment
Member
There was a problem hiding this comment.
pretty straightforward, lgtm apart from 2 nits
Erimelowo
requested changes
Aug 18, 2026
Erimelowo
left a comment
Erimelowo
left a comment
Member
There was a problem hiding this comment.
actually should be requesting changes lol, please look at the translation.ftl comment
move settings class definition to be the same order as the SettingConfigState field order
Erimelowo
approved these changes
Aug 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
solarxr protocol pr: SlimeVR/SolarXR-Protocol#221
this supersedes #1787