Skip to content

Add missing identifiers #83

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Slamdunk merged 1 commit into from
May 19, 2026
Merged

Add missing identifiers #83

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/PhpUnitFqcnAnnotationRule.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@ public function processNode(Node $node, Scope $scope): array
continue;
}
if (! $this->broker->hasClass($matches['className'])) {
$messages[] = RuleErrorBuilder::message(\sprintf('Class %s does not exist.', $matches['className']))->line($docComment->getStartLine() + $lineNumber)->build();
$messages[] = RuleErrorBuilder::message(\sprintf('Class %s does not exist.', $matches['className']))->identifier('phpunit.annotationClassNotFound')->line($docComment->getStartLine() + $lineNumber)->build();
}
}

Expand Down
2 changes: 1 addition & 1 deletion lib/UnusedVariableRule.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,7 @@ public function processNode(Node $node, Scope $scope): array
? \sprintf('Function %s()', $node->name)
: 'Closure function',
$varName
))->line($var->getAttribute('startLine'))->build();
))->identifier('variable.unused')->line($var->getAttribute('startLine'))->build();
}
}

Expand Down
2 changes: 1 addition & 1 deletion phpstan-baseline.neon
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ parameters:
path: lib/UnusedVariableRule.php

-
message: '#^Parameter \#1 \$line of method PHPStan\\Rules\\RuleErrorBuilder\<PHPStan\\Rules\\RuleError\>\:\:line\(\) expects int, mixed given\.$#'
message: '#^Parameter \#1 \$line of method PHPStan\\Rules\\RuleErrorBuilder\<PHPStan\\Rules\\IdentifierRuleError\>\:\:line\(\) expects int, mixed given\.$#'
identifier: argument.type
count: 1
path: lib/UnusedVariableRule.php
Expand Down
Loading