Refactor for Multi-Platform Support, Support Fabric#28
Open
Peashooter101 wants to merge 19 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
This PR splits SimpleNicks into three modules: core, paper, and fabric.
Core should contain all general logic for this plugin.
Paper and Fabric should have their own adapters for any platform specific operations.
Testing
The platforms should have parity between them. They should not differ in how they function.
Regression test the Paper build and verify we still support Paper 1.21.5-26.1.2. Check for feature parity on Fabric.
Fabric requires Fabric API as a dependency. This plugin should support Fabric 26.1.x (26.1-26.1.2).
Semver
The versioning of the platforms should be the same across both for major and minor.
I believe that the patch should differ between the platforms so that issues with fabric or paper individually will not hold releasing or creating no change releases.
Releasing
We are resolving issues we note on the Paper side. They appear to be pre-existing but we are not entirely sure.
Unsure if this should be released as v4.0.0 or v3.3.0 for both Paper and Fabric.
Issues
Closes #27 - Requests for Fabric Support