feat: ✨ Support waveform extraction from remote URLs on iOS and macOS#502
Open
lavigarg-simform wants to merge 1 commit into
Open
feat: ✨ Support waveform extraction from remote URLs on iOS and macOS#502lavigarg-simform wants to merge 1 commit into
lavigarg-simform wants to merge 1 commit into
Conversation
iOS/macOS decode waveforms via AVAudioFile, which only reads local files, so remote http(s) URLs failed extraction. The file is now downloaded to a temp file before decoding and cleaned up afterwards. Android's MediaExtractor handles network URIs directly, so its path is unchanged.
lavigarg-simform
force-pushed
the
fix/I054_waveform_from_url
branch
from
ed07d1a to
085d01d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds support for extracting waveforms from remote
http/httpsaudio URLs on iOS and macOS.Why it didn't work before:
AVAudioFile, which only reads local files.What changed:
MediaExtractoralready reads network URIs directly.Checklist
fix:,feat:,docs:etc).docsand added dartdoc comments with///.examplesordocs.Breaking Change?
Related Issues
Closes #54