fix: 🐛 Play mislabeled audio files on iOS/macOS#500
Open
lavigarg-simform wants to merge 1 commit into
Open
Conversation
6c3ff20 to
24ac0a2
Compare
AVFoundation routes strictly by file extension on iOS/macOS. Android can record AAC-in-MP4 yet name the file `.mp3`/`.aac`, so the player either fails to load or silently mis-parses it (e.g. an 8ms bogus duration that never throws). Sniff the real container from the file's leading magic bytes in Dart and,when it disagrees with the extension, prepare the player from a temp symlink carrying the correct extension so the right parser is chosen. Doing this once in the Dart layer covers iOS, macOS, and the waveform extractor path without duplicating logic across the native players.
24ac0a2 to
377ce1a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
On iOS/macOS the file extension picks the audio parser. Android often records AAC-in-MP4 but names the file
.mp3or.aac. The extension lies, so AVFoundation grabs the wrong parser and the file fails to load (or silently mis-parses, e.g. a bogus 8ms duration).What changed
Checklist
fix:,feat:,docs:etc).docsand added dartdoc comments with///.examplesordocs.Breaking Change?
Related Issues
Closes #113