fix: 🐛 Prevent nullptr == Tap() crash on iOS during recorder stream start#496
Open
lavigarg-simform wants to merge 1 commit into
Open
fix: 🐛 Prevent nullptr == Tap() crash on iOS during recorder stream start#496lavigarg-simform wants to merge 1 commit into
nullptr == Tap() crash on iOS during recorder stream start#496lavigarg-simform wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
On iOS, starting the recorder bytes stream could crash with a fatal
nullptr == Tap()exception (issue #487).RecorderBytesStreamEngine.attach()installed a tap on input bus 0 withoutclearing any existing tap first. Two paths left a stale tap on the bus:
attach()call beforedetach()(re-start without teardown).audioEngine.start()that threw — the tap was installed but neverremoved, leaking it onto the bus.
AVAudioEnginethrowsnullptr == Tap()when a tap is installed on a bus thatalready has one, crashing the app.
This PR makes
attach()reset prior state before installing:totalFrames.audioEngine.start(), removes the just-installed tap so itdoesn't leak onto the bus and crash the next
attach().No public API change.
Checklist
fix:,feat:,docs:etc).docsand added dartdoc comments with///.examplesordocs.Breaking Change?
Related Issues
Closes #487