Done. First task by SilentGitUser · Pull Request #1 · SilentGitUser/basecamp-example

SilentGitUser · 2022-01-08T10:38:50Z

Finish the first task.

First part of task is made for integer and double types
All compiler and runtime errors are commented

yegorjke

remove unnecessary couts and endls. make yours "print" function working. fix other comments

yegorjke · 2022-01-08T11:23:05Z

1_constants_variables_and_types/main.cpp

+auto adglob{34.5};
+
+// The function doesn't work because global variables sent with copy of value
+// template <typename T> inline void print_vars(string name, T  var, T * pvar, T & rvar)


I took a look at this function and it seems me overhead. I don't understand why you need to have all these passed params (I followed that these are a value, pointer, and reference of the same variable, right?), but if consider it as a real function of your library, do you really always have them in present on the stack? If not, you will have to pass them because the function demands (even so, print_vars("var", var, &var, var)).

If you don't want to pass params as values then consider passing them as [const] reference.

If I were you I would like to have the function which takes 1 required argument var, it is a variable being printed, and the optional one name or description. The function itself will perform printing the value, the address in memory, and the sizeof (and type of variable (see typeid) but it is optional). Some kind of this:

template<typename T> void print_variable_info(const T& var, const std::string& name = "") { std::string prefix = (name.empty()) ? "" : ("[" + name + "] "); std::cout << prefix << "Value: " << var << "\n"; std::cout << prefix << "Address: " << &var << "\n"; // Q: why it won't print address of var with type "char"? what is needed to do? std::cout << prefix << "Type: " << typeid(var).name() << "\n"; std::cout << prefix << "Sizeof: " << sizeof(var) << std::endl; }

It doesn't matter what you will pass to this function. If it confuses you how it will work with a pointer, then I would say that a pointer is a variable as well, but the value of a pointer is address (and the pointer has its own address as well as a common variable)

Done. The source code is changed to use template function.

std::cout << prefix << "Address: " << &var << "\n"; doesn't work because the compiler interpret &char variable as c-style string and tries to print whole string instead of address of pointer. To print address of char pointer we need to use static_cast<const void *>.

yegorjke · 2022-01-08T12:19:50Z

1_constants_variables_and_types/main.cpp

+
+    cout << "---------------------------------------------------------------------" << endl;
+
+    cout << "Value of iglob: " << iglob << endl;


remake it with the proposed function above

... and all "cout"s are below

yegorjke · 2022-01-08T12:25:17Z

1_constants_variables_and_types/main.cpp

+    //ERROR: error: invalid conversion from ‘const char*’ to ‘int’ [-fpermissive]
+
+    return 0;
+}


add to habits leaving an extra newline at the EOF.

yegorjke · 2022-01-08T12:33:10Z

1_constants_variables_and_types/main.cpp

+    cout << "c - const" << endl;
+    cout << "s - static" << endl;
+    cout << "glob - global" << endl;
+    cout << "loc - local" << endl << endl;


a lot of "endl"s force the IO buffer to flush. it costs the time of your [future] programs. it is useful to flush the buffer when you are sure that it must be done. consider of "\n" in some places.

Got it. Thanks. I will use the advice in the future.

yegorjke · 2022-01-08T12:55:29Z

1_constants_variables_and_types/main.cpp

+    unsigned char * puchar{&ucloc};
+    cout << "*puchar <- ucloc " << endl << "*puchar=" << int (*puchar) << endl;
+    *puchar=*puchar +1;
+    cout << "increment *puchar " << endl << "*puchar=" << int (*puchar) << endl;


ok, but what is happened to ucloc?

Added print of ucloc after pointer value increment.

yegorjke · 2022-01-08T12:59:25Z

1_constants_variables_and_types/main.cpp

+    float floc{12.34};
+    double dloc{12.3456};
+    char cloc{'l'};
+    unsigned char ucloc{'k'};


what if ucloc is assigned with a small integer (for example, 12)? what will be printed?

Nothing will be printed until k>32. Because from 0 to 31 are not printable signs, 32 is space and from 33 are printable signs.

SilentGitUser · 2022-01-13T07:39:55Z

Made corrections in accordance with the comments

Done. First task

a733461

yegorjke suggested changes Jan 8, 2022

View reviewed changes

SilentGitUser marked this pull request as draft January 11, 2022 21:36

SilentGitUser force-pushed the 1_constants_variables_and_types branch from 506e7a0 to 6b7a7aa Compare January 13, 2022 07:48

SilentGitUser marked this pull request as ready for review January 13, 2022 07:49

Made corrections according with the comments

c7efbf5

SilentGitUser force-pushed the 1_constants_variables_and_types branch from 6b7a7aa to c7efbf5 Compare January 13, 2022 09:35

yegorjke approved these changes Jan 24, 2022

View reviewed changes


		cout << "---------------------------------------------------------------------" << endl;

		cout << "Value of iglob: " << iglob << endl;

Conversation

SilentGitUser commented Jan 8, 2022

Finish the first task.

Uh oh!

yegorjke left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

SilentGitUser commented Jan 13, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants