perf(tooltip-plugin): limit amount of items when hover with mouse#9966
Closed
H4ad wants to merge 1 commit intoSigNoz:mainfrom
Closed
perf(tooltip-plugin): limit amount of items when hover with mouse#9966H4ad wants to merge 1 commit intoSigNoz:mainfrom
H4ad wants to merge 1 commit intoSigNoz:mainfrom
Conversation
Contributor
|
Closing this PR @H4ad, we've made the tooltip items virtualised. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📄 Summary
Opened just to discuss a little bit, there's any need to render all the legends when you can only see the first one's since you can't scroll in that dialog?
Related #9784
Note
Caps tooltip content to the first 20 entries.
MAX_TOOLTIP_ITEMS = 20and limits the render loop toMath.min(sortedValues.length, MAX_TOOLTIP_ITEMS)intooltipPlugin.ts.Written by Cursor Bugbot for commit 8c60e8b. This will update automatically on new commits. Configure here.