Skip to content

Conversation

@aks07
Copy link
Contributor

@aks07 aks07 commented Jan 8, 2026

📄 Summary

Introduces attribute variant awareness and deduping in the options UI.

  • Uses composite attribute keys via buildAttributeKey and parsing helpers to uniquely identify columns and prevent duplicates in AddColumn and logs options menu
  • New FieldVariantBadges component and styles to display fieldDataType and fieldContext tags for attributes with the same name in option lists and selected columns
  • Updates OptionsMenu/LogsFormatOptionsMenu logic, styling, and popover focus/blur handling; widens nested menu and adds truncation wrappers
  • Fixes duration_nano type to number in defaults
  • Adds unit/UI tests covering badge rendering and variant display in both Logs and Traces views

✅ Changes

  • Feature: Brief description
  • Bug fix: Brief description

🔍 Related Issues

Closes #
https://github.com/SigNoz/engineering-pod/issues/3345


📸 Screenshots / Screen Recording (if applicable / mandatory for UI related changes)

Before:

Attribute keys with same name and different dataTypes breaking the options in trace explorer

Screen.Recording.2026-01-08.at.2.25.10.PM.mov

After:

Show badges for multi-variant attribute keys in traces and logs column options
Traces

Screen.Recording.2026-01-08.at.3.57.14.PM.mov

Logs Options
image


📋 Checklist

  • Dev Review
  • Test cases added (Unit/ Integration / E2E)
  • Manually tested the changes

Note

Introduces attribute-variant awareness and deduping in options UIs.

  • Add FieldVariantBadges (with styles) to show fieldDataType and fieldContext for attributes with identical names
  • Use composite attribute keys via buildAttributeKey/parseAttributeKey and getOptionLabelCounts to uniquely select/remove columns and detect multi-variant labels in OptionsMenu and LogsFormatOptionsMenu
  • Update add-column lists and selected columns to render badges; widen nested menu and add truncation wrappers; manage popover focus/blur
  • Fix default duration_nano type to number
  • Add unit/UI tests covering variant badge rendering in Logs and Traces views

Written by Cursor Bugbot for commit bddd80a. This will update automatically on new commits. Configure here.

@aks07 aks07 requested a review from a team as a code owner January 8, 2026 02:42
@github-actions github-actions bot added the bug Something isn't working label Jan 8, 2026
Copy link

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is being reviewed by Cursor Bugbot

Details

Your team is on the Bugbot Free tier. On this plan, Bugbot will review limited PRs each billing cycle for each member of your team.

To receive Bugbot reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial.

@srikanthccv
Copy link
Member

srikanthccv commented Jan 8, 2026

Hi @aks07 , please hold the PR for some time, there is alternative proposal to handle the conflicting field keys in explorer, https://signoz-team.slack.com/archives/C02B85R4R0A/p1767770511772329. I sent an optional invite to you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants