perf(app-routes): lazy load message queues and meter components#9916
Closed
H4ad wants to merge 1 commit intoSigNoz:mainfrom
Closed
perf(app-routes): lazy load message queues and meter components#9916H4ad wants to merge 1 commit intoSigNoz:mainfrom
H4ad wants to merge 1 commit intoSigNoz:mainfrom
Conversation
Member
|
@H4ad - Please check the conflict. |
13fd25c to
3c3e13c
Compare
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
This is the final PR Bugbot will review for you during this billing cycle
Your free Bugbot reviews will reset on February 3
Details
Your team is on the Bugbot Free tier. On this plan, Bugbot will review limited PRs each billing cycle for each member of your team.
To receive Bugbot reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial.
3c3e13c to
752e384
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📄 Summary
These two components probably were forgot to be included in the lazy load components.
✅ Changes
Before:
After:
🧪 How to Test
📋 Checklist
Note
Improves route-level code-splitting by lazy-loading previously eagerly-loaded pages.
Loadableexports forMessagingQueues,MeterExplorer, andAlertTypeSelectionPageinpageComponents.tsroutes.tsto import these components frompageComponents(instead of direct imports) and use them for existing routesMessagingQueuesMainPageexport toMessagingQueuesfor consistencyWritten by Cursor Bugbot for commit 752e384. This will update automatically on new commits. Configure here.