Fixes the "Umbrella header for module Sift cannot be found"#147
Open
dbarden wants to merge 1 commit intoSiftScience:masterfrom
Open
Fixes the "Umbrella header for module Sift cannot be found"#147dbarden wants to merge 1 commit intoSiftScience:masterfrom
dbarden wants to merge 1 commit intoSiftScience:masterfrom
Conversation
Creates a `include` header that will contain the headers that should be distributed. This avoid copying all the headers and solves the compile time error shown in SiftScience#114
Contributor
|
@dbarden the issue should have been addressed already, should we close this one? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Creates a
includeheader that will contain the headers that should be distributed. It has some symlinks to the headers that should be public.Summary
This avoid copying all the headers and solves the compile time error shown in #114
Testing
Integrate the sift package via SPM and compile the project
Checklist