Fix invalid enum for discount classes in 2026-01#3953
Merged
jonathanhamel4 merged 1 commit into2026-01from Feb 24, 2026
Merged
Conversation
jonathanhamel4
force-pushed
the
jh_fix-discount-classes-2026-01
branch
from
c010a0f to
53e6e36
Compare
jonathanhamel4
changed the title
devisscher
approved these changes
Feb 23, 2026
Contributor
Author
|
cc @vividviolet just making sure I'm ok to add a patch to 2026-01. |
Member
|
Yeah, go for it |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Background
When updating our internal app to 2026-01, I realized that our ui-extension type contract was wrong and that the type was invalid. The data returned from admin returns a lower cased value, coming from a string union type.
I will also make a PR to 2026-04-rc.