Create mocks for the entire Customer Account extension API#3905
Open
kumar303 wants to merge 1 commit into02-12-create_mocks_for_the_entire_point-of-sale_extension_apifrom
Conversation
Contributor
Author
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
This was referenced Feb 12, 2026
kumar303
force-pushed
the
02-12-create_mocks_for_the_entire_customer_account_extension_api
branch
from
8c15ddb to
4a0e80d
Compare
kumar303
force-pushed
the
02-12-create_mocks_for_the_entire_point-of-sale_extension_api
branch
from
3e06b36 to
072992f
Compare
kumar303
force-pushed
the
02-12-create_mocks_for_the_entire_customer_account_extension_api
branch
from
4a0e80d to
27fe3a8
Compare
kumar303
force-pushed
the
02-12-create_mocks_for_the_entire_point-of-sale_extension_api
branch
from
072992f to
34763c2
Compare
kumar303
force-pushed
the
02-12-create_mocks_for_the_entire_customer_account_extension_api
branch
from
27fe3a8 to
8fccf50
Compare
kumar303
force-pushed
the
02-12-create_mocks_for_the_entire_point-of-sale_extension_api
branch
from
34763c2 to
c11b76b
Compare
kumar303
force-pushed
the
02-12-create_mocks_for_the_entire_customer_account_extension_api
branch
from
8fccf50 to
b6b83e9
Compare
kumar303
force-pushed
the
02-12-create_mocks_for_the_entire_point-of-sale_extension_api
branch
from
c11b76b to
bb5b1ed
Compare
kumar303
force-pushed
the
02-12-create_mocks_for_the_entire_customer_account_extension_api
branch
3 times, most recently
from
bab7729 to
a303042
Compare
kumar303
force-pushed
the
02-12-create_mocks_for_the_entire_point-of-sale_extension_api
branch
2 times, most recently
from
344b671 to
af00386
Compare
kumar303
force-pushed
the
02-12-create_mocks_for_the_entire_customer_account_extension_api
branch
from
a303042 to
2db9df6
Compare
kumar303
force-pushed
the
02-12-create_mocks_for_the_entire_point-of-sale_extension_api
branch
from
af00386 to
7049f9e
Compare
kumar303
force-pushed
the
02-12-create_mocks_for_the_entire_customer_account_extension_api
branch
2 times, most recently
from
6e15cd7 to
83b81e0
Compare
kumar303
force-pushed
the
02-12-create_mocks_for_the_entire_point-of-sale_extension_api
branch
from
7049f9e to
1a6144c
Compare
kumar303
force-pushed
the
02-12-create_mocks_for_the_entire_customer_account_extension_api
branch
from
83b81e0 to
69f7238
Compare
kumar303
force-pushed
the
02-12-create_mocks_for_the_entire_point-of-sale_extension_api
branch
from
1a6144c to
62487cd
Compare
kumar303
force-pushed
the
02-12-create_mocks_for_the_entire_customer_account_extension_api
branch
from
69f7238 to
bb90420
Compare
kumar303
force-pushed
the
02-12-create_mocks_for_the_entire_point-of-sale_extension_api
branch
from
62487cd to
4fd668d
Compare
kumar303
force-pushed
the
02-12-create_mocks_for_the_entire_customer_account_extension_api
branch
from
bb90420 to
9707ec1
Compare
kumar303
force-pushed
the
02-12-create_mocks_for_the_entire_point-of-sale_extension_api
branch
from
4fd668d to
d8892b1
Compare
kumar303
force-pushed
the
02-12-create_mocks_for_the_entire_customer_account_extension_api
branch
from
9707ec1 to
2b029e3
Compare
kumar303
force-pushed
the
02-12-create_mocks_for_the_entire_customer_account_extension_api
branch
2 times, most recently
from
ed2acf4 to
9c42619
Compare
kumar303
force-pushed
the
02-12-create_mocks_for_the_entire_point-of-sale_extension_api
branch
2 times, most recently
from
6588884 to
dc785e2
Compare
kumar303
force-pushed
the
02-12-create_mocks_for_the_entire_customer_account_extension_api
branch
from
9c42619 to
b1d8f34
Compare
kumar303
force-pushed
the
02-12-create_mocks_for_the_entire_point-of-sale_extension_api
branch
from
dc785e2 to
ca3a20d
Compare
kumar303
force-pushed
the
02-12-create_mocks_for_the_entire_customer_account_extension_api
branch
2 times, most recently
from
49e571c to
31b4fbd
Compare
kumar303
force-pushed
the
02-12-create_mocks_for_the_entire_point-of-sale_extension_api
branch
from
ca3a20d to
6afbc5a
Compare
kumar303
force-pushed
the
02-12-create_mocks_for_the_entire_customer_account_extension_api
branch
from
31b4fbd to
cc4dd82
Compare
kumar303
force-pushed
the
02-12-create_mocks_for_the_entire_point-of-sale_extension_api
branch
from
6afbc5a to
e04bdfe
Compare
kumar303
force-pushed
the
02-12-create_mocks_for_the_entire_customer_account_extension_api
branch
from
cc4dd82 to
d058148
Compare
kumar303
force-pushed
the
02-12-create_mocks_for_the_entire_point-of-sale_extension_api
branch
from
e04bdfe to
4c9b881
Compare
kumar303
force-pushed
the
02-12-create_mocks_for_the_entire_customer_account_extension_api
branch
from
d058148 to
e592271
Compare
kumar303
force-pushed
the
02-12-create_mocks_for_the_entire_point-of-sale_extension_api
branch
from
4c9b881 to
1ab00cd
Compare
kumar303
force-pushed
the
02-12-create_mocks_for_the_entire_customer_account_extension_api
branch
from
e592271 to
776e604
Compare
kumar303
force-pushed
the
02-12-create_mocks_for_the_entire_point-of-sale_extension_api
branch
from
1ab00cd to
724d295
Compare
kumar303
force-pushed
the
02-12-create_mocks_for_the_entire_customer_account_extension_api
branch
from
776e604 to
d619193
Compare
kumar303
force-pushed
the
02-12-create_mocks_for_the_entire_point-of-sale_extension_api
branch
from
724d295 to
2364cea
Compare
kumar303
force-pushed
the
02-12-create_mocks_for_the_entire_customer_account_extension_api
branch
from
d619193 to
ec9fbb4
Compare
kumar303
force-pushed
the
02-12-create_mocks_for_the_entire_point-of-sale_extension_api
branch
from
2364cea to
6ec4c50
Compare
|
|
||
| const customerAccountMockFactories: CustomerAccountMockFactory = { | ||
| // StandardApi only | ||
| 'customer-account.page.render': createStandardApiProperties, |
Member
There was a problem hiding this comment.
Should we also add the navigation api? https://shopify.dev/docs/api/customer-account-ui-extensions/latest/apis/navigation
navigate is available in all targets, full page extensions have more properties available
Contributor
Author
There was a problem hiding this comment.
oh yeah. Is this available for Admin, too? I can't tell.
Contributor
Author
There was a problem hiding this comment.
I added a mock for all surfaces (on the base branch). Good call, thanks!
Member
There was a problem hiding this comment.
Why all surfaces? 😅 Checkout doesn't have it, right?
Contributor
Author
There was a problem hiding this comment.
if at least two surfaces include it then I think it's good to include it everywhere. We could make navigate() throw an error if the extension under test is in an unsupported target.
kumar303
force-pushed
the
02-12-create_mocks_for_the_entire_point-of-sale_extension_api
branch
from
6ec4c50 to
32fb2a4
Compare
kumar303
force-pushed
the
02-12-create_mocks_for_the_entire_customer_account_extension_api
branch
from
ec9fbb4 to
44a456a
Compare
kumar303
force-pushed
the
02-12-create_mocks_for_the_entire_customer_account_extension_api
branch
from
44a456a to
f7c9ffa
Compare
kumar303
force-pushed
the
02-12-create_mocks_for_the_entire_point-of-sale_extension_api
branch
from
32fb2a4 to
a026d49
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow up to #3899 that adds a complete, type-safe mock of the Customer Account extension API
👁️ How to review this PR