Skip to content

Ensure singleton class is created when we find an extend#730

Merged
vinistock merged 1 commit intomainfrom
04-07-create_singleton_classes_on_extend
Apr 15, 2026
Merged

Ensure singleton class is created when we find an extend#730
vinistock merged 1 commit intomainfrom
04-07-create_singleton_classes_on_extend

Conversation

@vinistock
Copy link
Copy Markdown
Member

@vinistock vinistock commented Apr 8, 2026

I noticed that in the following snippet:

class Foo
  extend Bar
end

It was not possible to ask any ancestor information about Foo::<Foo>. We need to ensure that the singleton is created if an extend happens. This PR ensures that.

Copy link
Copy Markdown
Member Author

vinistock commented Apr 8, 2026

@vinistock vinistock force-pushed the 04-06-fix_top_level_resolution_algorithm branch from d1c948d to 3bf8916 Compare April 8, 2026 14:55
@vinistock vinistock force-pushed the 04-07-create_singleton_classes_on_extend branch from 29b8c72 to 243ce6d Compare April 8, 2026 14:55
@vinistock vinistock self-assigned this Apr 8, 2026
@vinistock vinistock force-pushed the 04-06-fix_top_level_resolution_algorithm branch from 3bf8916 to bb9979c Compare April 8, 2026 15:32
@vinistock vinistock force-pushed the 04-07-create_singleton_classes_on_extend branch from 243ce6d to 82a080b Compare April 8, 2026 15:32
@vinistock vinistock added the bugfix A change that fixes an existing bug label Apr 8, 2026
@vinistock vinistock marked this pull request as ready for review April 8, 2026 15:40
@vinistock vinistock requested a review from a team as a code owner April 8, 2026 15:40
@vinistock vinistock force-pushed the 04-06-fix_top_level_resolution_algorithm branch from bb9979c to fbf8915 Compare April 8, 2026 19:20
@vinistock vinistock force-pushed the 04-07-create_singleton_classes_on_extend branch from 82a080b to 5978d65 Compare April 8, 2026 19:20
@vinistock vinistock force-pushed the 04-06-fix_top_level_resolution_algorithm branch from fbf8915 to 9381da4 Compare April 13, 2026 15:07
@vinistock vinistock force-pushed the 04-07-create_singleton_classes_on_extend branch from 5978d65 to 04a905b Compare April 13, 2026 15:08
@vinistock vinistock force-pushed the 04-06-fix_top_level_resolution_algorithm branch from 9381da4 to 9176994 Compare April 15, 2026 14:23
@vinistock vinistock force-pushed the 04-07-create_singleton_classes_on_extend branch 2 times, most recently from d477a6c to ba9a7a9 Compare April 15, 2026 14:40
@vinistock vinistock force-pushed the 04-06-fix_top_level_resolution_algorithm branch from 9176994 to 31b1cc8 Compare April 15, 2026 14:40
@vinistock vinistock force-pushed the 04-07-create_singleton_classes_on_extend branch 2 times, most recently from 4f14fc1 to d123c91 Compare April 15, 2026 14:47
@vinistock vinistock force-pushed the 04-06-fix_top_level_resolution_algorithm branch from 31b1cc8 to 00d4fa1 Compare April 15, 2026 14:47
Copy link
Copy Markdown
Member Author

vinistock commented Apr 15, 2026

Merge activity

  • Apr 15, 2:55 PM UTC: A user started a stack merge that includes this pull request via Graphite.
  • Apr 15, 3:03 PM UTC: Graphite rebased this pull request as part of a merge.
  • Apr 15, 3:08 PM UTC: @vinistock merged this pull request with Graphite.

@vinistock vinistock changed the base branch from 04-06-fix_top_level_resolution_algorithm to graphite-base/730 April 15, 2026 14:56
@vinistock vinistock changed the base branch from graphite-base/730 to main April 15, 2026 15:02
@vinistock vinistock force-pushed the 04-07-create_singleton_classes_on_extend branch from d123c91 to fd751f2 Compare April 15, 2026 15:03
@vinistock vinistock merged commit fe5a724 into main Apr 15, 2026
36 checks passed
@vinistock vinistock deleted the 04-07-create_singleton_classes_on_extend branch April 15, 2026 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bugfix A change that fixes an existing bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants