Ensure singleton class is created when we find an extend#730
Merged
Conversation
Member
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
This was referenced Apr 8, 2026
d1c948d to
3bf8916
Compare
29b8c72 to
243ce6d
Compare
3bf8916 to
bb9979c
Compare
243ce6d to
82a080b
Compare
bb9979c to
fbf8915
Compare
82a080b to
5978d65
Compare
fbf8915 to
9381da4
Compare
5978d65 to
04a905b
Compare
alexcrocha
approved these changes
Apr 15, 2026
9381da4 to
9176994
Compare
d477a6c to
ba9a7a9
Compare
9176994 to
31b1cc8
Compare
4f14fc1 to
d123c91
Compare
31b1cc8 to
00d4fa1
Compare
Member
Author
Merge activity
|
d123c91 to
fd751f2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

I noticed that in the following snippet:
It was not possible to ask any ancestor information about
Foo::<Foo>. We need to ensure that the singleton is created if an extend happens. This PR ensures that.