Show chain of references in Ractor errors #935
+298
−49
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Improve the messages of exceptions raised by the Ractor implementation. When an object fails to be made shareable with `Ractor.make_shareable` or when an unshareable object is accessed through module constants or module instance variables, the error message now includes the chain of references that leads to the unshareable value.
etiennebarrie
force-pushed
the
ractor-error-reference-chain
branch
from
d37bed4 to
89a62f7
Compare
| !RB_OBJ_SHAREABLE_P(block_self)) { | ||
| if (!rb_ractor_shareable_p_continue(block_self, chain)) { | ||
| if (chain) { | ||
| if (NIL_P(*chain)) { |
There was a problem hiding this comment.
Why are we duplicating the chain_append logic here?
| "Proc's self is not shareable: %" PRIsVALUE, | ||
| self); | ||
| if (chain) { | ||
| if (NIL_P(*chain)) { |
| " from block self #<Foo @ivar={}>\n" \ | ||
| " from hash default value\n" \ | ||
| " from instance variable @ivar\n" \ | ||
| " from instance variable @foo", %q{ |
There was a problem hiding this comment.
The chain approach makes sense to me, but I'm finding the error message a little hard to parse - it's not immediately obvious to me from the message what objects the ivars are attached to, or where the hash values are coming from. Is it worth using rb_inspect or rb_obj_as_string here or is the performance an issue?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve the messages of exceptions raised by the Ractor implementation.
When an object fails to be made shareable with
Ractor.make_shareableor when an unshareable object is accessed through module constants or module instance variables, the error message now includes the chain of references that leads to the unshareable value.