Start indexing and resolving Rubydex graph#3992
Open
vinistock wants to merge 1 commit intorubydex_adoption_feature_branchfrom
Open
Start indexing and resolving Rubydex graph#3992vinistock wants to merge 1 commit intorubydex_adoption_feature_branchfrom
vinistock wants to merge 1 commit intorubydex_adoption_feature_branchfrom
Conversation
vinistock
added
server
Base automatically changed from
02-10-adopt_rubydex
to
rubydex_adoption_feature_branch
March 6, 2026 16:54
vinistock
force-pushed
the
03-03-start_indexing_and_resolving_rubydex_graph
branch
from
d3fa68d to
c7cf7ea
Compare
19 tasks
vinistock
force-pushed
the
rubydex_adoption_feature_branch
branch
from
4d27e4e to
5eae955
Compare
vinistock
force-pushed
the
03-03-start_indexing_and_resolving_rubydex_graph
branch
from
c7cf7ea to
de5e731
Compare
vinistock
changed the base branch from
rubydex_adoption_feature_branch
to
03-18-upgrade_rubydex_to_v0.1.0.beta9
Base automatically changed from
03-18-upgrade_rubydex_to_v0.1.0.beta9
to
rubydex_adoption_feature_branch
March 18, 2026 17:14
vinistock
force-pushed
the
03-03-start_indexing_and_resolving_rubydex_graph
branch
from
de5e731 to
e0a1f4a
Compare
alexcrocha
reviewed
Mar 18, 2026
Comment on lines
+1231
to
+1235
| progress("indexing-progress", message: "Indexing workspace...") | ||
| @global_state.graph.index_workspace | ||
|
|
||
| progress("indexing-progress", message: "Resolving graph...") | ||
| @global_state.graph.resolve |
Contributor
There was a problem hiding this comment.
Should this be inside its own Thread.new block as well, like the existing indexing? Or is Rubydex handling it in some other way
Member
Author
There was a problem hiding this comment.
The old indexing happens inside a thread because it's too slow and we don't want to block requests while we're still indexing.
Rubydex is fast enough that we don't have to run indexing in a thread, which will simplify a lot of our code.
For example, right now, we need code to bust the code lens cache and trigger a refresh after indexing because we may have computed incorrect lenses if a request comes in before indexing is finished.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
This PR starts indexing and resolving the Rubydex graph on boot and for tests. Note that consuming incremental changes is not yet a part of the API, so this PR doesn't address that yet.
Our strategy, for smaller and easier to review PRs, will be to maintain both indexing mechanisms while we migrate each request one by one. That way, we don't have to review a massive amount of changes and we can rely on CI.
Implementation
The implementation makes sure we're: