Compute humanized bytes lazily#593
Draft
dnagoda wants to merge 1 commit into
Draft
Conversation
This was referenced Jul 6, 2026
BytesContainer eagerly built a `humanized` String (pretty-printed JSON or a hex dump) on every construction, even though it is only needed when a FunctionRunResult is displayed. Batch mode constructs a BytesContainer per input row and never renders the humanized form, so this was pure per-row overhead. Remove the stored `humanized` field and replace it with a HumanizedBytes Display wrapper that formats on demand. Single-run output is unchanged. Invalid JSON output now retains its raw bytes so the wrapper can reproduce the previous lossy-UTF8 rendering. Verified with: - cargo build - cargo test Assisted-By: devx/c659e918-9568-4750-b122-e3890447348a
a8174bb to
9d39117
Compare
5fea7f9 to
3f69067
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📚 Stack (bottom → top)
--batch-full-outputopt-inWhy
BytesContainereagerly built ahumanizedString(pretty-printed JSON or ahex dump) on every construction, even though it's only needed when a
FunctionRunResultis actually displayed. Batch mode constructs aBytesContainerper input row and never renders the humanized form, so this waspure per-row overhead.
What
humanizedfield; replace it with aHumanizedBytesDisplaywrapper that formats on demand.
previous lossy-UTF8 rendering.
Testing
cargo buildcargo test