Skip to content

Fix items height normalization after layout change #2096

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
VickyStash wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix items height normalization after layout change #2096

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 10 additions & 2 deletions src/recyclerview/layout-managers/LinearLayoutManager.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -135,8 +135,16 @@ export class RVLinearLayoutManagerImpl extends RVLayoutManager {
layout.minHeight = targetMinHeight;
}
newTallestItem.minHeight = 0;
this.tallestItem = newTallestItem;
this.tallestItemHeight = newTallestItem.height;
// When items shrink (targetMinHeight = 0), reset tracking so the
// next cycle re-detects the tallest item after repaint and properly
// re-applies minHeight for all layouts.
if (targetMinHeight === 0) {
this.tallestItem = undefined;
this.tallestItemHeight = 0;
} else {
this.tallestItem = newTallestItem;
this.tallestItemHeight = newTallestItem.height;
}
}
}

Expand Down
Loading