Test should-render target mappings for product configuration extensions - #8191
Closed
one20 wants to merge 1 commit into
Closed
Test should-render target mappings for product configuration extensions#8191one20 wants to merge 1 commit into
one20 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
Fixes https://github.com/shop/issues-on-ramps/issues/900
The CLI target mapping needs regression coverage for the two product configuration surfaces that expose a
rendertarget with a correspondingshould-rendertarget. UI Extensions Shopify/ui-extensions#4600 and Core https://github.com/shop/issues-on-ramps/issues/899 are separate dependencies for this work.WHAT is this pull request doing?
Adds focused tests for
getShouldRenderTargetcovering these target conversions:admin.product-details.configuration.render→admin.product-details.configuration.should-renderadmin.product-variant-details.configuration.render→admin.product-variant-details.configuration.should-renderUI Extensions Shopify/ui-extensions#4600 and Core https://github.com/shop/issues-on-ramps/issues/899 remain separate dependencies and are not included in this CLI-only change.
How to test your changes?
pnpm --filter @shopify/app vitest run src/cli/models/extensions/specifications/ui_extension.test.ts— 55 tests passedpnpm --filter @shopify/app type-check— passedpnpm --filter @shopify/app lint— passedgit diff --check— passedPost-release steps
No post-release steps.
Checklist
patchfor bug fixes ·minorfor new features ·majorfor breaking changes) and added a changeset withpnpm changeset add(not applicable; test-only change)