Skip to content

[Security] Harden ExtensionServerClient ID generation #7637

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
gonzaloriestra wants to merge 1 commit into from
+8 −1
Closed

[Security] Harden ExtensionServerClient ID generation #7637

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions packages/ui-extensions-server-kit/src/ExtensionServerClient/ExtensionServerClient.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -163,6 +163,12 @@ describe('ExtensionServerClient', () => {
})

describe('initialization', () => {
test('generates a random UUID as id', () => {
const client = new ExtensionServerClient(defaultOptions)
const uuidRegex = /^[0-9a-f]{8}-[0-9a-f]{4}-[0-9a-f]{4}-[0-9a-f]{4}-[0-9a-f]{12}$/i
expect(client.id).toMatch(uuidRegex)
})

test('connects to the target websocket', async () => {
// Create client
const client = new ExtensionServerClient(defaultOptions)
Expand Down
3 changes: 2 additions & 1 deletion packages/ui-extensions-server-kit/src/ExtensionServerClient/ExtensionServerClient.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,8 @@ export class ExtensionServerClient implements ExtensionServer.Client {
private uiExtensionsByUuid: Record<string, ExtensionServer.UIExtension> = {}

constructor(options: DeepPartial<ExtensionServer.Options> = {}) {
this.id = (Math.random() + 1).toString(36).substring(7)
// Security: Use a cryptographically secure random UUID to prevent ID predictability
this.id = globalThis.crypto.randomUUID()
this.options = getValidatedOptions({
...options,
connection: {
Expand Down
Loading