[Tests] Remove redundant filesystem mocks in stage-file.test.ts#7636
[Tests] Remove redundant filesystem mocks in stage-file.test.ts#7636gonzaloriestra wants to merge 1 commit into
Conversation
Remove unused mocks for readFile and fileSize in stage-file.test.ts. These mocks were redundant as the production code in stage-file.ts uses Buffer operations rather than disk access.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
WHY are these changes introduced?
Technical debt cleanup. The test file
packages/app/src/cli/services/bulk-operations/stage-file.test.tscontained redundant mocks for filesystem operations (readFileandfileSize) that are not used by the code under test, which instead usesBuffer.fromandbuffer.length.WHAT is this pull request doing?
Removes
vi.mock('@shopify/cli-kit/node/fs')and associated unused mock setups inpackages/app/src/cli/services/bulk-operations/stage-file.test.ts.How to test your changes?
CI
Post-release steps
Checklist
patchfor bug fixes ·minorfor new features ·majorfor breaking changes) and added a changeset withpnpm changeset addPR created automatically by Jules for task 18354233134098056568 started by @gonzaloriestra