[Security] Harden devConsoleAssetsMiddleware against path traversal#7625
[Security] Harden devConsoleAssetsMiddleware against path traversal#7625gonzaloriestra wants to merge 1 commit into
Conversation
This PR hardens the `devConsoleAssetsMiddleware` against path traversal attacks by ensuring that any requested asset is contained within the intended root directory. We now resolve the candidate path and use the `isSubpath` utility to verify it remains within the `rootDirectory`. Regression tests have been added to verify that valid assets are served correctly and that traversal attempts (e.g., using `..`) result in a 404 error.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
WHY are these changes introduced?
The
devConsoleAssetsMiddlewarewas vulnerable to path traversal attacks because it joined user-providedassetPathwith therootDirectorywithout validating that the resulting path remained within the intended directory.WHAT is this pull request doing?
devConsoleAssetsMiddlewareinpackages/app/src/cli/services/dev/extension/server/middlewares.tsto useresolvePathandisSubpathfor path validation.packages/app/src/cli/services/dev/extension/server/middlewares.test.ts.utilities.sendErrorfor error handling in the middleware.How to test your changes?
CI handles testing. You can also run the specific tests:
pnpm --filter app vitest run src/cli/services/dev/extension/server/middlewares.test.tsChecklist
patchfor bug fixes ·minorfor new features ·majorfor breaking changes) and added a changeset withpnpm changeset addPR created automatically by Jules for task 15346866280291798229 started by @gonzaloriestra