Stricter schema validation for extension and web TOMLs#7124
Open
gonzaloriestra wants to merge 1 commit intomainfrom
Open
Stricter schema validation for extension and web TOMLs#7124gonzaloriestra wants to merge 1 commit intomainfrom
gonzaloriestra wants to merge 1 commit intomainfrom
Conversation
Contributor
Coverage report
Test suite run success4004 tests passing in 1532 suites. Report generated by 🧪jest coverage report action from 290f0c5 |
Contributor
|
We detected some changes at Caution DO NOT create changesets for features which you do not wish to be included in the public changelog of the next CLI release. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
Related to https://shopify.slack.com/archives/C05E3BDFDRB/p1774273758576219
WHAT is this pull request doing?
shopify.extension.toml(unified format) andshopify.web.tomlby adding.strict()toUnifiedSchemaandbaseWebConfigurationSchema[metaobjects]in extension TOML instead of app TOML) to be silently ignoredAppErrorsmechanism, consistent with howshopify.app.tomlalready rejects unsupported sectionsHow to test your changes?
Add an unknown field to
shopify.extension.tomlorshopify.web.tomland run deployMeasuring impact
How do we know this change was effective? Please choose one:
Checklist