Fixed an infinite loop when selecting desktop icons#97
Open
m417z wants to merge 1 commit intoShizukuIchi:masterfrom
Open
Fixed an infinite loop when selecting desktop icons#97m417z wants to merge 1 commit intoShizukuIchi:masterfrom
m417z wants to merge 1 commit intoShizukuIchi:masterfrom
Conversation
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/shizukuichi/winXP/AwLsNmPBA6QutX2DU9Uxf3jguHPk |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The problem was that a new
onIconsSelectedfunction was created on each render, causing the following infinite loop:WinXP()is called.onIconsSelectedfunction is passed to<Icons />.useEffectis called insideIcons(), andsetSelectedIconsis called.setSelectedIconstriggers a dispatch, causingWinXP()to be called again.To fix this, I wrapped
setSelectedIconswithuseCallback. And while at it, I wrapped all other functions.