Skip to content

WIP: Calculator#59

Open
matricali wants to merge 9 commits intoShizukuIchi:masterfrom
matricali:feature/calculator
Open

WIP: Calculator#59
matricali wants to merge 9 commits intoShizukuIchi:masterfrom
matricali:feature/calculator

Conversation

@matricali
Copy link
Copy Markdown

🚧 WORK IN PROGRESS 🚧

PR related to #54

Calculator

  • Addition
  • Substraction
  • Division
  • Multiplication
  • Memory operations (Set, Restore, Clear, Addition)
  • Square root

@vercel
Copy link
Copy Markdown

vercel Bot commented Apr 15, 2019

This pull request is automatically deployed with Now.
To access deployments, click Details below or on the icon next to each push.

Latest deployment for this branch: https://winxp-git-fork-matricali-feature-calculator.shizukuichi.now.sh

@SoffiMeower
Copy link
Copy Markdown
Contributor

Screenshot 2019-04-15 at 2 41 51 PM
Seems legit.

@panmona
Copy link
Copy Markdown

panmona commented Apr 15, 2019

Nice first version!

Not sure if you're aware of this but it would be great if the buttons were raised a bit and that you can see them being pressed down when you click on them.
Also M+ should be aligned with the 0 button.
What I mean is shown here:
image

@SoffiMeower
Copy link
Copy Markdown
Contributor

Also Backspace is clipping off button on a small screen.

Comment thread src/WinXP/apps/Calculator/index.js Outdated
FIX typo (thanks @ghostslayer989)

Co-Authored-By: ghostslayer989 <45863583+ghostslayer989@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants