add support for switching between 2011 and 2021 version of llsoa#65
Merged
Herald-TUOS merged 14 commits intodevelopfrom Mar 3, 2026
Conversation
Contributor
Author
|
FYI, I got the Scottish boundaries from https://www.nrscotland.gov.uk/publications/2022-census-geography-products/ |
Contributor
Author
|
@JamieTaylor-TUOS , I'm tempted to mock the tests that fetch data from external APIs in this PR. I think the tests are failing due to the external APIs. What is the best thing to do here? |
JamieTaylor-TUOS
approved these changes
Mar 2, 2026
Contributor
JamieTaylor-TUOS
left a comment
JamieTaylor-TUOS
left a comment
There was a problem hiding this comment.
Left some suggestions, but none are critical - LGTM!
Co-authored-by: Jamie Taylor <jamie.taylor@sheffield.ac.uk>
Herald-TUOS
deleted the
59-add-support-for-switching-between-2011-and-2021-lsoa-boundary-definitions-when-geocodingreverse-geocoding
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.